Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Codicons to the latest release (0.0.26) #191

Closed
kumattau opened this issue Dec 10, 2021 · 3 comments · Fixed by #206
Closed

Update Codicons to the latest release (0.0.26) #191

kumattau opened this issue Dec 10, 2021 · 3 comments · Fixed by #206
Assignees
Milestone

Comments

@kumattau
Copy link
Contributor

kumattau commented Dec 10, 2021

README.md says

msc prefix holds Microsoft's Codicons 0.0.25 with its 385 icons.

but it looks like a working version between 0.0.25 and 0.0.26 is bundled in the package.
I checked that the bundled font and charmap are different from 0.0.25 and 0.0.26.

Now, the latest Codicons 0.0.26 has been released.
So I think that Codicons should be updated to the latest to fix the incorrect version.

@dalthviz
Copy link
Member

Makes sense to me @kumattau 👍

@dalthviz dalthviz added this to the v1.2.0 milestone Dec 10, 2021
@dalthviz dalthviz changed the title Update Codicons to the latest release Update Codicons to the latest release (0.0.26) Dec 10, 2021
@kumattau
Copy link
Contributor Author

I will send the PR before the end of the year.

@kumattau
Copy link
Contributor Author

Thanks for working on it for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants