Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jedi dependency upper bound #21296

Closed
3 of 7 tasks
AdamWill opened this issue Aug 29, 2023 · 3 comments · Fixed by #21367
Closed
3 of 7 tasks

Update Jedi dependency upper bound #21296

AdamWill opened this issue Aug 29, 2023 · 3 comments · Fixed by #21367
Milestone

Comments

@AdamWill
Copy link

AdamWill commented Aug 29, 2023

Issue Report Checklist

  • Searched the issues page for similar reports
  • Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
  • [-] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
  • [-] Could not reproduce inside jupyter qtconsole (if console-related)
  • [-] Tried basic troubleshooting (if a bug/error)
    • Restarted Spyder
    • Reset preferences with spyder --reset
    • Reinstalled the latest version of Anaconda
    • Tried the other applicable steps from the Troubleshooting Guide
  • Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description

spyder currently sets an upper bound on its jedi dependency of 0.19.0, in several files - binder/environment.yml, external-deps/python-lsp-server/pyproject.toml, requirements/main.yml, setup.py and spyder/dependencies.py at least. Upstream lsp, which is where this dependency comes from I believe, bumped it to 0.20.0 recently with the note that there "don't seem to be any breaking changes". spyder should probably inherit this bump so it can be used with jedi 0.19.

What steps reproduce the problem?

  1. Try and install spyder with jedi 0.19.

What is the expected output? What do you see instead?

It fails, but it should be allowed.

Versions

This is present in current git head and all supported branches.

@AdamWill
Copy link
Author

I'd send a PR for this, but I couldn't find an explanation of the procedure for bumping a dependency that comes from lsp like this.

@ccordoba12
Copy link
Member

Hey @AdamWill, thanks for reporting and for the offer to help.

I'd send a PR for this, but I couldn't find an explanation of the procedure for bumping a dependency that comes from lsp like this.

That's right, we don't have one, but the procedure is like this:

  • Open a PR against our 5.x branch (our maintenance one), so this can be part of our next version (5.5.0).
  • Synchronize our python-lsp-server subrepo, as described here (use the last command on that section). That will update the dependency in external-deps/python-lsp-server/pyproject.toml.
  • Bump our Jedi requirement to >=0.17.2,<0.20 in the other files you mentioned (binder/environment.yml, requirements/main.yml, setup.py and spyder/dependencies.py).

That should do it, but let me know if you have other questions about this process.

@musicinmybrain
Copy link
Contributor

That should do it, but let me know if you have other questions about this process.

I think I’ve done it correctly…

musicinmybrain added a commit to musicinmybrain/spyder that referenced this issue Sep 24, 2023
This comes from python-lsp-server, which supports 0.19.x since 1.8.0.

Fixes spyder-ide#21296.
musicinmybrain added a commit to musicinmybrain/spyder that referenced this issue Sep 25, 2023
This comes from python-lsp-server, which supports 0.19.x since 1.8.0.

Fixes spyder-ide#21296.
ccordoba12 added a commit that referenced this issue Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants