-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jedi dependency upper bound #21296
Comments
I'd send a PR for this, but I couldn't find an explanation of the procedure for bumping a dependency that comes from lsp like this. |
Hey @AdamWill, thanks for reporting and for the offer to help.
That's right, we don't have one, but the procedure is like this:
That should do it, but let me know if you have other questions about this process. |
I think I’ve done it correctly… |
This comes from python-lsp-server, which supports 0.19.x since 1.8.0. Fixes spyder-ide#21296.
This comes from python-lsp-server, which supports 0.19.x since 1.8.0. Fixes spyder-ide#21296.
Issue Report Checklist
conda update spyder
(orpip
, if not using Anaconda)jupyter qtconsole
(if console-related)spyder --reset
Problem Description
spyder currently sets an upper bound on its jedi dependency of 0.19.0, in several files -
binder/environment.yml
,external-deps/python-lsp-server/pyproject.toml
,requirements/main.yml
,setup.py
andspyder/dependencies.py
at least. Upstream lsp, which is where this dependency comes from I believe, bumped it to 0.20.0 recently with the note that there "don't seem to be any breaking changes". spyder should probably inherit this bump so it can be used with jedi 0.19.What steps reproduce the problem?
What is the expected output? What do you see instead?
It fails, but it should be allowed.
Versions
This is present in current git head and all supported branches.
The text was updated successfully, but these errors were encountered: