Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PySide2 support #6894

Closed
looooo opened this issue Apr 4, 2018 · 11 comments
Closed

PySide2 support #6894

looooo opened this issue Apr 4, 2018 · 11 comments

Comments

@looooo
Copy link

looooo commented Apr 4, 2018

I am trying to get spyder working with pyside2. I am using qt5.6 and pyside2 from conda-forge channel.

So far there are some problems in the initialization (qtpy) and some not available members of QtCore:

  • QtCore.qround which I replaced with pythons round
  File "~/conda/envs/pyside2/lib/python3.6/site-packages/qtawesome/iconic_font.py", line 24, in <module>
    from qtpy.QtCore import QObject, QPoint, QRect, qRound, Qt
ImportError: cannot import name 'qRound'

  • QWebEngineSettings (which I simple disabled)
  File "~/projects/spyder/spyder/widgets/browser.py", line 18, in <module>
    from qtpy.QtWebEngineWidgets import (QWebEnginePage, QWebEngineSettings,
ImportError: cannot import name 'QWebEngineSettings'
Fatal Python error: deallocating None

  • QRegularExpression (should be the same as QRegExpr)
  File "~/projects/spyder/spyder/widgets/mixins.py", line 40, in <module>
    from qtpy.QtCore import QRegularExpression
ImportError: cannot import name 'QRegularExpression'
Fatal Python error: deallocating None
  • QAbstractItemModel.index (no idea)
Traceback (most recent call last):
  File "~/projects/spyder/spyder/widgets/explorer.py", line 969, in filterAcceptsRow
    index = self.sourceModel().index(row, 0, parent_index)
NotImplementedError: pure virtual method 'QAbstractItemModel.index()' not implemented.

depends on https://bugreports.qt.io/browse/PYSIDE-570

are there any plans to support pyside2. It seems like it is almost possible.

@ccordoba12
Copy link
Member

are there any plans to support pyside2. It seems like it is almost possible.

No. It'd be a terrible waste of time for us to support PySide2 when it's still very buggy and it doesn't offer any gain to the project.

Closing this one for the time being.

@stonebig
Copy link
Contributor

stonebig commented May 8, 2018

@looooo You may check at the bottom of this page the advance of PySide2 towards PyQt5 parity https://wiki.qt.io/Qt_for_Python_Missing_Bindings

Today they are 75 points behind PyQt5, at PySide-5.11a1 (alpha1)

You may check their progress on this metric after their preview release, end of may 2018.

@stonebig
Copy link
Contributor

stonebig commented May 9, 2018

the patch for Qround is there https://github.com/spyder-ide/qtawesome/pull/81/files. will re-propose in a more compatible way

@stonebig
Copy link
Contributor

no change of mind ?

@ccordoba12
Copy link
Member

If you're willing to put from your own time and add PySide2 to CircleCI, fix all failing tests and be willing to keep fixing tests in the future, then sure, we'll support PySide2.

If not, then we're happy to be a PyQt5 project only because there's nothing important to gain for us in supporting PySide2.

@ccordoba12 ccordoba12 reopened this Aug 3, 2019
@ccordoba12 ccordoba12 added this to the v4.0betaX milestone Aug 3, 2019
@ccordoba12 ccordoba12 changed the title pyside2 support PySide2 support Aug 3, 2019
@ccordoba12 ccordoba12 modified the milestones: v4.0rc, future Sep 15, 2019
@goanpeca goanpeca removed this from the future milestone Feb 23, 2020
@stonebig
Copy link
Contributor

there may be a bus factor

@looooo
Copy link
Author

looooo commented Sep 23, 2020

Is there any work going on for PySide2 support? I would like to make a tight integration of FreeCAD and spyder for development but this is currently not possible because FreeCAD uses PySide2 and is not able to use PyQt, while for spyder it is exactly the other way...

I tried this branch but I get:

pkg_resources.DistributionNotFound: The 'pyqtwebengine<5.13' distribution was not found and is required by spyder

Is there any work going on in this direction? What can we do to accelerate development?

@ccordoba12
Copy link
Member

Sorry but we haven't had time to work on this. You're welcome to continue my work on master and add support.

Otherwise you'll have to wait for Spyder 5 (to be released next year), which will come for sure with support for PySide2.

@stonebig
Copy link
Contributor

small remark: Qt is working on PyPy support for PySide6 (as of 24 june 2021) https://wiki.qt.io/Qt_for_Python_Development_Notes

@ccordoba12
Copy link
Member

Wow, that's really impressive!

@stonebig
Copy link
Contributor

on my PC, pyzo is now working on PySide6-6.2, with latest + tweaked QtPy-master + a small enough pyzo change.
pyzo/pyzo#742 (comment)

@ccordoba12 ccordoba12 added this to the v5.2.0 milestone Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants