Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Don't show Kite dialog the third time Spyder starts #17013

Merged
merged 1 commit into from Dec 13, 2021

Conversation

ccordoba12
Copy link
Member

Description of Changes

  • Since Kite is not unsupported anymore, there's no need to keep showing that dialog.
  • Besides, that dialog wrongly leads users to think that Spyder still works with Kite.

Issue(s) Resolved

Fixes #16744

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v5.2.1 milestone Dec 13, 2021
@ccordoba12 ccordoba12 self-assigned this Dec 13, 2021
dalthviz
dalthviz previously approved these changes Dec 13, 2021
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 ! LGTM 👍

@dalthviz
Copy link
Member

dalthviz commented Dec 13, 2021

Note: Needs a rebase after #17015 gets merged

@dalthviz dalthviz merged commit 8a216d1 into spyder-ide:5.x Dec 13, 2021
dalthviz added a commit that referenced this pull request Dec 13, 2021
@ccordoba12 ccordoba12 deleted the dont-show-kite-dialog branch December 14, 2021 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants