Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower support #37

Closed
kensaggy opened this issue Feb 11, 2018 · 3 comments
Closed

Bower support #37

kensaggy opened this issue Feb 11, 2018 · 3 comments

Comments

@kensaggy
Copy link

Hi there,

Can you add support to make this library bower-installable?

I know the name is already taken by this fork, which doesn't seem to be under active development or maintenance (this is what we used until now, but we want to move to your fork as it solves multiple issues that are still open there) but maybe you can publish it under a different name..

@nene
Copy link
Collaborator

nene commented Feb 11, 2018

I've never used bower, so I know little of what's needed for adding bower support. Would you be interested in creating a pull request?

@kensaggy
Copy link
Author

Hi @nene - Thanks for the quick reply :) much appreciated.

There isn't much to making it available in Bower...
If you want a short-name install you basically need to register the package (find a name) and run bower register <my-package-name> <git-endpoint>

Personally I don't really mind the short-name, we can also just run bower install https://github.com/zeroturnaround/sql-formatter.git

What you're really missing for browser support is basically committing the "compiled" or dist path to the repo - so that we can include it in the markup like this

Now you can just run npm run build locally and commit it like this fork of sql-formatter did - see last 4 commits or you can probably do a more-robust build which when merging builds and commits the dist automatically for you - but that's obviously more complex (either using commit hooks, or travis to do the automated).

@nene
Copy link
Collaborator

nene commented Feb 11, 2018

Hmm... I don't really like the idea of committing compiled artifacts to the repository. Is there an alternative way to achieve Bower support?

From Bower homepage I read the following message:

...psst! While Bower is maintained, we recommend using Yarn and Webpack for front-end projects

I take it to mean that Bower is deprecated and you're better off using something else.

Therefore unless there is a simpler way of supporting bower, I'm not really willing to do that.

@nene nene closed this as completed Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants