Support AWS partitions with role-based credentials #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbayles
commented
Jul 15, 2020
| @@ -26,13 +26,14 @@ | |||
| ACCESS_KEY_ID_RE = re.compile('[A-Z0-9]{20}') | |||
| SECRET_ACCESS_KEY_RE = re.compile('[A-Za-z0-9/+=]{40}') | |||
| TOKEN_RE = re.compile('[A-Za-z0-9/+=]+') | |||
| AWS_PARTITIONS = frozenset({'aws', 'aws-cn', 'aws-us-gov'}) | |||
There was a problem hiding this comment.
The list of valid partitions is here.
jklukas
approved these changes
Jul 15, 2020
|
Excellent - many thanks for the quick response. Might I request a release with this change incorporated? Thanks again. |
|
Done. 0.8.1 is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#88 added support for IAM Role-based authentication. This allows the user to supply an
aws_account_idandiam_role_nameto use with theCOPYandUNLOADcommands.The existing code constructs an ARN for the IAM role from these parameters. However, it assumes that the account exists in the
awspartition.This assumption is right for most AWS regions - e.g.
us-east-1,eu-central-1. But it's not right for the AWS GovCloud (US) regions or the AWS China regions.This PR adds an
aws_partitionparameter for both theCOPYandUNLOADcommands that allows those other regions to be used. It defaults to'aws'such that the default behavior is unchanged.This is a common mistake when dealing with ARNs. See the AWS docs for information about the format, including the partition.