Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upasync_creation_runners broken by v0.7.0 #139
Comments
This comment has been minimized.
This comment has been minimized.
I dont use semver for any of my projects since I can't isolate releases to be only features or only bugfixes, so the .0 at the end would never be used and the major version would be huge. the async runner change is a mistake since I don't use that feature I forgot that people would be using it with decorators. the only solution I can see for now is to revert the change. |
This comment has been minimized.
This comment has been minimized.
part of the change, at least. i have no interest in breaking compatibility. |
This comment has been minimized.
This comment has been minimized.
sqlalchemy-bot
commented
Dec 12, 2018
Mike Bayer has proposed a fix for this issue: Restore the API for async_creation_runner in all cases https://gerrit.sqlalchemy.org/1010 |
This comment has been minimized.
This comment has been minimized.
when that review passes, it's going to be release 0.7.1 tonight. if would be very helpful if you could take a review of it. added some tests for async_creation_runner which was obviously a problem as well. |
This comment has been minimized.
This comment has been minimized.
it's ready to go. I'd like to release right now. |
This comment has been minimized.
This comment has been minimized.
Looks good! Thank you! |
This comment has been minimized.
This comment has been minimized.
ok |
goodspark commentedDec 11, 2018
•
edited
Specifically, the changes to pull out
creator_args
from thecreator
function.Here's a minimal test expanded from the current documentation:
The last call fails with:
Basically #136 broke backwards compatibility. I'm not sure if dogpile uses semver, but if so, then it should probably have a major version increment now.
The fix is trivial, but the documentation should also be updated: