Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support nested tuple unpacking in for loops #368

Closed
wants to merge 3 commits into from
Closed

Support nested tuple unpacking in for loops #368

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0932dc
Support nested tuple unpacking in for loops
mtc-mlx Nov 10, 2022
9f953ac
_FOR_LOOP regex test cleanup
mtc-mlx Nov 10, 2022
3f15a87
Apply pep8 format; add changelog entry
mtc-mlx Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions mako/codegen.py
View file
Open in desktop
Expand Up @@ -1251,8 +1251,13 @@ def visitCallTag(self, node):


_FOR_LOOP = re.compile(
r"^for\s+((?:\(?)\s*[A-Za-z_][A-Za-z_0-9]*"
r"(?:\s*,\s*(?:[A-Za-z_][A-Za-z0-9_]*),??)*\s*(?:\)?))\s+in\s+(.*):"
r"^for\s+((?:\(?)\s*"
r"(?:\(?)\s*[A-Za-z_][A-Za-z_0-9]*"
r"(?:\s*,\s*(?:[A-Za-z_][A-Za-z_0-9]*),??)*\s*(?:\)?)"
r"(?:\s*,\s*(?:"
r"(?:\(?)\s*[A-Za-z_][A-Za-z_0-9]*"
r"(?:\s*,\s*(?:[A-Za-z_][A-Za-z_0-9]*),??)*\s*(?:\)?)"
r"),??)*\s*(?:\)?))\s+in\s+(.*):"
)


Expand Down
10 changes: 10 additions & 0 deletions test/test_loop.py
View file
Open in desktop
Expand Up @@ -31,6 +31,16 @@ def test__FOR_LOOP(self):
"x",
"[y+1 for y in [1, 2, 3]]",
),
(
"for ((key1, val1), (key2, val2)) in pairwise(dict.items()):",
"((key1, val1), (key2, val2))",
"pairwise(dict.items())"
),
(
"for (key1, val1), (key2, val2) in pairwise(dict.items()):",
"(key1, val1), (key2, val2)",
"pairwise(dict.items())"
),
):
match = _FOR_LOOP.match(statement)
assert match and match.groups() == (target_list, expression_list)
Expand Down