Support nested tuple unpacking in for loops #368
Conversation
|
how many layers does it support? |
|
Only two layers, like in the example I gave. I see I forgot to run flake on the test folder; oops. |
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 9f953ac of this pull request into gerrit so we can run tests and reviews and stuff
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 9f953ac of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change 9f953ac: https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/4187 |
|
looks like it needs pre-commit run, that will fix up the pep8 problems. also we need a changelog file in the doc/build/unreleased/ folder. See 9257602 for an example of this. |
|
Thanks for the guidance :) |
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 3f15a87 of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset 3f15a87 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/4187 |
|
mike bayer (zzzeek) wrote: thanks! View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/4187 |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/4187 has been merged. Congratulations! :) |
Fixed issue where unpacking nested tuples in a for loop using would raise a
"couldn't apply loop context" error if the loop context was used. The regex
used to match the for loop expression now allows the list of loop variables
to contain parenthesized sub-tuples. Pull request courtesy Matt Trescott.
For example:
~~~
for (key1, val1), (key2, val2) in itertools.pairwise(dict.items()):
...
~~~
This is really just "kicking the can down the road" so to speak, because
it doesn't allow an infinite number of layers of tuples, but
it helps somewhat.
Closes: #368
Pull-request: sqlalchemy/mako#368
Pull-request-sha: 3f15a87266a36306826d460cddc7699dd62a9c43
Change-Id: I52915acb8904daf7071d8c92e1de352f200131ec
4 participants
For example:
This is really just "kicking the can down the road" so to speak, because it doesn't allow an infinite number of layers of tuples, but it helps somewhat.