Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install-DbaFirstResponderKit fails on newest release of frk #3328

Closed
jstexasdba opened this issue Mar 1, 2018 · 11 comments · Fixed by #3360
Closed

Install-DbaFirstResponderKit fails on newest release of frk #3328

jstexasdba opened this issue Mar 1, 2018 · 11 comments · Fixed by #3360
Assignees

Comments

@jstexasdba
Copy link
Collaborator

Bug Report

Install-DbaFirstResponderKit now fails to install or update.
Error: The request was aborted: Could not create SSL/TLS secure channel.

@potatoqualitee
Copy link
Member

Oh gosh, what is going on there? I get it too.

@potatoqualitee
Copy link
Member

Yet i can download with Chrome

@potatoqualitee
Copy link
Member

image

Invoke-WebRequest on the url fails as well out of the box

@niphlod
Copy link
Contributor

niphlod commented Mar 1, 2018

give [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12 a try

@jstexasdba
Copy link
Collaborator Author

Yep, that works. Just updated the 2 lines on the install file, force import and it is executing fine.

@jstexasdba jstexasdba self-assigned this Mar 1, 2018
@jstexasdba
Copy link
Collaborator Author

syncing up with dev and will be submitting a PR as soon as I can.

@potatoqualitee
Copy link
Member

Consider https://codeload.github.com/ prefix instead of changing settings?

@potatoqualitee
Copy link
Member

@jstexasdba
Copy link
Collaborator Author

Created PR with only that one change as it works perfectly. Thank you!

@jstexasdba
Copy link
Collaborator Author

PR #3329

@niphlod niphlod closed this as completed Mar 4, 2018
@wsmelton
Copy link
Member

This still fails on latest release of module, 0.9.301.

PS C:\WINDOWS\system32> Install-DbaFirstResponderKit -SqlInstance localhost -Database NewDatabase
WARNING: [Install-DbaFirstResponderKit][03:56:37] Couldn't download the First Responder Kit. Download and install manually from
https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/archive/master.zip. | The remote server returned an error: (400) Bad Request.
PS C:\WINDOWS\system32> $Error[0] | select *


writeErrorStream      : True
PSMessageDetails      :
Exception             : System.Exception: The remote server returned an error: (400) Bad Request. ---> System.Net.WebException: The
                        remote server returned an error: (400) Bad Request.
                           at Microsoft.PowerShell.Commands.WebRequestPSCmdlet.GetResponse(WebRequest request)
                           at Microsoft.PowerShell.Commands.WebRequestPSCmdlet.ProcessRecord()
                           --- End of inner exception stack trace ---
TargetObject          :
CategoryInfo          : InvalidOperation: (:) [Write-Error], Exception
FullyQualifiedErrorId : dbatools_Install-DbaFirstResponderKit,Stop-Function
ErrorDetails          : The remote server returned an error: (400) Bad Request.
InvocationInfo        : System.Management.Automation.InvocationInfo
ScriptStackTrace      : at Stop-Function, C:\Program Files\WindowsPowerShell\Modules\dbatools\0.9.301\allcommands.ps1: line 88913
                        at Install-DbaFirstResponderKit<Begin>, C:\Program
                        Files\WindowsPowerShell\Modules\dbatools\0.9.301\allcommands.ps1: line 43471
                        at <ScriptBlock>, <No file>: line 1
PipelineIterationInfo : {0, 1}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants