Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install-DbaInstance - Test for allowed ACTION before adding SQLTEMPDBFILECOUNT #7437

Merged
merged 3 commits into from
Jun 18, 2021

Conversation

andreasjordan
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

I want to be able to run ACTION=Uninstall and use -ConfigurationFile for that.
It's a similar case like #6479 that was addressed with #6480.
To be totally flexible I asked the documentation what ACTIONs allow SQLTEMPDBFILECOUNT:
https://docs.microsoft.com/en-us/sql/database-engine/install-windows/install-sql-server-from-the-command-prompt
So I added these 5 ACTIONs.
I moved the test so that there is no unsused call to the computer for no reason.

@nvarscar : What do you think? If you would like to solve it some other way, I'm open for feedback.

@nvarscar nvarscar self-requested a review June 16, 2021 03:54
Copy link
Contributor

@nvarscar nvarscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, no reason to add tempdb file count upon uninstall

@potatoqualitee
Copy link
Member

Thank you both! 🥳

@potatoqualitee potatoqualitee merged commit 65056be into development Jun 18, 2021
@potatoqualitee potatoqualitee deleted the InstallDbaInstance_ConfigurationFile branch June 18, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants