Get-DbaConnectedInstance / Disconnect-DbaInstance

[potatoqualitee]

Proof of concept so far -- totally works

[andreasjordan]

What about connections to the same instance with different Credentials or with different parameters?

[potatoqualitee]

we can make the "key" using psboundparameters 🤔

[potatoqualitee]

but then it may become unrecognizable

[andreasjordan]

Maybe an array of connection objects as the value.

[potatoqualitee]

ahh! without an index!

[potatoqualitee]

boo, can't detect dupes

[potatoqualitee]

ahh connectionstring as an index!

[potatoqualitee]

love itttttt

[andreasjordan]

[potatoqualitee]

Interesting! I didn't realize that admin wasn't parsable, I'll handle it

[andreasjordan]

We would need a change in the dll for that. Was planned here: #6831 (comment)

[andreasjordan]

Problem 1: Disconnect should also remove the entry from the hash.
Problem 2: If you open more that one non-pooled connection, you only have one entry in the hash for more that one connection, so only one gets closed.
Problem 3: This only works for non-pooled connection. Pooled connections can only be closed with Clear-DbaConnectionPool.

[potatoqualitee]

1. Yep, realized that after and added a note for myself when Get showed too much
2. No idea how to handle this
3. Yep, it's in the description docs for Disconnect

[andreasjordan]

About 2.: What about an array as the value to the key connectionstring:

Instead of $script:connectionhash[$server.ConnectionContext.ConnectionString] = $server something like:

if (-not $script:connectionhash[$server.ConnectionContext.ConnectionString]) {
    $script:connectionhash[$server.ConnectionContext.ConnectionString] = @( )
}
$script:connectionhash[$server.ConnectionContext.ConnectionString] += $server

You could also take the server name as key then:

if (-not $script:connectionhash[$server.Name]) {
    $script:connectionhash[$server.Name] = @( )
}
$script:connectionhash[$server.Name] += $server

[potatoqualitee]

Mmm check it out?

Import-Module ./dbatools.psm1 -Force; Get-DbaDatabase -SqlInstance workstation | Out-null; $a = Connect-DbaInstance -SqlInstance localhost -SqlConnectionOnly; Get-DbaDatabase -SqlInstance workstation | Out-null; Get-DbaConnectedInstance

[andreasjordan]

As the internal key is still the connection string, it might look like this:

So I have one connection with connections string A and two connections with connection string B.
It's ok, but might confuse the user.

[potatoqualitee]

sweet, check it now!

[andreasjordan]

Yes, looks good!

[potatoqualitee]

Booom! Will merge once tests pass.