New-DbaDatabase: Fix issues with generated filenames

[andreasjordan]

Type of Change

• Bug fix (non-breaking change, fixes New-DbaDatabase + (Test-Bound) - DataFileSuffix & LogFileSuffix Don't trigger advancedconfig or using default  #7981 )
• New feature (non-breaking change, adds functionality, fixes # )
• Breaking change (effects multiple commands or functionality, fixes # )
• Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
• Adding code coverage to existing functionality
• Pester test is included
• If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
• Unit test is included
• Documentation
• Build system

Fixes for the linked issue.

But this will also effect the filenames when used without advanced parameters, as now the "special" filenames are created always:

[potatoqualitee]

I'm sorry, I'm confused. Does this deviate from Microsoft's default naming standard? Or does it better align with it?

[andreasjordan]

Let me share two screenshot.

This one is done with the current version of dbatools:

Database "tsql" is for reference. Database dba1 does not use any "advanced" parameter, database "dba2" uses an advanced parameter to run the advanded section of the code. Here you see the different names for both logical and physical filenames.

This one is from the current branch in this pull request:

Same commands, same output for the first two. But the last one now follows the same rules like in "tsql".

[potatoqualitee]

hell yeah! thank you 💯 💯 💯