-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix the recordset numbers in the Browse Data tab
This improves the accuracy of the number of the last row in the recordset number label at the bottom of the Browse Data tab by using the seemingly more accurate visualIndexAt approach instead of the rowAt approach from before and by taking the horizontal scrollbar into account. It also updates the label when resizing the row heights or column widths. See issue #232.
- Loading branch information
1 parent
b006530
commit cee3523
Showing
2 changed files
with
9 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee3523
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just got a crash, and it might be related to this change:
cee3523
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh thanks! I'll take a lot at that 😄
cee3523
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try again with the patch I have just committed? It didn't crash on my system but I think I covered all the possible causes of this crash 😄
cee3523
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It happened again after this change at a later point, which I've managed to solve (in my system, at least) in 0113d15