Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for the release 3.12 wanted #2124

Closed
mgrojo opened this issue Feb 14, 2020 · 93 comments · Fixed by #2130
Closed

Translations for the release 3.12 wanted #2124

mgrojo opened this issue Feb 14, 2020 · 93 comments · Fixed by #2130

Comments

@mgrojo
Copy link
Member

mgrojo commented Feb 14, 2020

We are in the process of releasing our next stable version (3.12.0) of 'DB Browser for SQLite' with many new features and corrections.

Once again we kindly ask our users to help us in making DB4S better by translating it to their languages or updating the translation of the last release (when available).

The *.ts files are already updated on the master branch, and we are not going to modify the strings unless needed to include some correction.

You can read brief indications here about how to do it. I'll be happy to assist you in the process, in case you had any doubt.

I'll ping here all the translators who have helped us in the past, so they get a notification. Please, report back if you want to help again. When there are more than one volunteers, they can share out the work and/or review each other translations. Happy translation!

lang complete translators
ar_SA
  • Yes
  • @SafaAlfulaij
    cs
  • @MrJiggers
    de
  • Yes
  • @FriedrichFroebel
    en_GB
  • @glawrence
    es_ES
  • Yes
  • @lulol, @mgrojo
    fr
  • Yes
  • @mvt91
    it
  • Yes
  • @Feyn-Man, @GortiZ6
    ja (new)
  • Yes
  • @hrwatahiki
    ko_KR
  • @progh2, @ChangJoo-Park
    pl
  • Yes
  • @bartlomiej-przymus, @wojnilowicz
    pt_BR
  • Yes
  • @bernardosulzbach
    ru
  • @schdub, @zvova7890, @VanDerSam
    tr
  • Yes
  • @firateski
    uk_UA
  • @keedhost
    zh
  • Needs review
  • @bssthu, @mercury233
    zh_TW
  • @PeterDaveHello

    Source string changes after translation started:

    When we're near the final release build, we should check this list of "source string changes ..." in case some languages need those done.

    @FriedrichFroebel
    Copy link
    Contributor

    I will have a look at updating the German translation in the next days.

    @bernardosulzbach
    Copy link
    Contributor

    I will make some time for this in the next 24 hours.

    @GortiZ6
    Copy link
    Contributor

    GortiZ6 commented Feb 14, 2020 via email

    @hrwatahiki
    Copy link
    Contributor

    Thanks for accepting my pull request.
    I will update the Japanese file to 3.12 by 2020-02-18 (UTC).

    @mvt91
    Copy link
    Contributor

    mvt91 commented Feb 14, 2020 via email

    @firateski
    Copy link
    Contributor

    I'm planning to complete Turkish translations in the next 3-4 days. Do you have any tool suggestions to easily manage translations?

    @bernardosulzbach
    Copy link
    Contributor

    I'm planning to complete Turkish translations in the next 3-4 days. Do you have any tool suggestions to easily manage translations?

    Besides Qt Linguist? If that's the case, then no. I think most people translating are just using Linguist.

    @mvt91
    Copy link
    Contributor

    mvt91 commented Feb 15, 2020 via email

    @mvt91
    Copy link
    Contributor

    mvt91 commented Feb 15, 2020

    Here is the file... I don't know where to push it :(

    Please remove the .zip extension
    sqlb_fr.ts.zip

    @justinclift
    Copy link
    Member

    Thanks @mvt91, just added that in daedace. 😄

    As a thought, there were two spelling mistakes in our source (english) sentences, fixed a few hours ago.

    Would you be ok to grab the .ts file again (it has the corrected sentences in it now), and translate those two as well?

    @justinclift
    Copy link
    Member

    @SafaAlfulaij @hrwatahiki Same question as above... there were two spelling mistakes fixed in our source text a few hours ago. That will mean your translations aren't quite 100% any more.

    Any interest in fixing those as well? 😄

    @firateski
    Copy link
    Contributor

    firateski commented Feb 15, 2020

    I'm planning to complete Turkish translations in the next 3-4 days. Do you have any tool suggestions to easily manage translations?

    Besides Qt Linguist? If that's the case, then no. I think most people translating are just using Linguist.

    I just heard about the Qt Linguist. Qt Linguist looks fine, thank you.

    @mvt91
    Copy link
    Contributor

    mvt91 commented Feb 15, 2020 via email

    @mvt91
    Copy link
    Contributor

    mvt91 commented Feb 15, 2020 via email

    @mvt91
    Copy link
    Contributor

    mvt91 commented Feb 15, 2020

    Hi Justin (bis),

    Here is the file updated, as early this morning, please remove the .zip extension.
    Best regards
    sqlb_fr.ts.zip

    @justinclift
    Copy link
    Member

    @mvt91 Thanks, added in d8b25e0. 😄

    @hrwatahiki
    Copy link
    Contributor

    @justinclift Thank you. Now I've download the new files and I'm updating them.

    @SafaAlfulaij
    Copy link
    Contributor

    SafaAlfulaij commented Feb 15, 2020

    Puzzle strings, and untranslatable string:
    https://github.com/sqlitebrowser/sqlitebrowser/blob/master/src/AboutDialog.cpp#L21
    Please use proper placeholders for variables.

    @justinclift
    Copy link
    Member

    @hrwatahiki Thanks. 😄

    @SafaAlfulaij That's a bit confusing. What should that example be instead? 😄

    @justinclift
    Copy link
    Member

    Oops. Accidentally closed this. 😉

    @firateski
    Copy link
    Contributor

    firateski commented Feb 15, 2020

    @hrwatahiki Thanks. 😄

    @SafaAlfulaij That's a bit confusing. What should that example be instead? 😄

    If I understood @SafaAlfulaij correctly, he pointed out that we need parameterized strings in 'AboutDialog.cpp' (which is referenced by Safa), because in some languages ​​we use a different word order than English to make sentences.

    For example, in the following code block string concatenation is okay for English but not for Turkish:

    tr("Built for ") + QSysInfo::buildAbi()...

    English: "Built for X"
    Turkish: "X için derlendi" <- We need to put X before the predicate for Turkish.

    In short, parameterized strings allow us to make a sentence in a valid order.

    P.S: I'm able to fix this problem by using another form of the sentence like "Derleme mimarisi: X", so it's not a huge problem for Turkish, at least for now.

    @bernardosulzbach
    Copy link
    Contributor

    bernardosulzbach commented Feb 15, 2020

    In short, parameterized strings allow us to make a sentence in a valid order.

    Some Portuguese translations could be made more "natural" if the source strings contained more context for the sentence.

    @mercury233
    Copy link
    Contributor

    It seems that v3.12.x didn't include my last pr (#2231), can you please merge it?

    @justinclift
    Copy link
    Member

    Oops. Ok, just merged it. 😄

    @mercury233
    Copy link
    Contributor

    Now the only problem of zh translation is the dialog buttons of qt, as I mentioned in #2124 (comment)

    @justinclift
    Copy link
    Member

    Yeah. I don't know if there's any way we can fix that. 😦

    @justinclift
    Copy link
    Member

    Actually, maybe we could just add the zh translations to our own copy of the Qt translation files on our build server...

    @mercury233
    Copy link
    Contributor

    can you try this? https://github.com/wisaly/qtbase_zh

    @justinclift
    Copy link
    Member

    justinclift commented Jun 10, 2020

    Ok, I've just added the .qm file from that repo to the 64-bit Qt translations folder, and just started our nightly build script.

    In about 40 minutes, an updated version of our Win64 build should be on the nightlies server. When that new build is ready, are you able to check if it improves things?

        https://nightlies.sqlitebrowser.org/latest/

    @mercury233
    Copy link
    Contributor

    It don't work, and the string I just commited to v3.12.x didn't appear
    image

    @justinclift
    Copy link
    Member

    Ahhh. That build pulled from the master branch, it's expected it won't get changes to the v3.12.x one.

    I was hoping those Qt buttons at the bottom would change though. 😦

    @mvt91
    Copy link
    Contributor

    mvt91 commented Jun 10, 2020 via email

    @justinclift
    Copy link
    Member

    @mvt91 Sorry, but that didn't work. GitHub ignores attachments in email reply messages. 😦

    You'll probably need to use the web interface instead. 😄

    @mvt91
    Copy link
    Contributor

    mvt91 commented Jun 10, 2020 via email

    @mvt91
    Copy link
    Contributor

    mvt91 commented Jun 10, 2020

    Hi Justin,

    Here is the file (zipped, .ts files are not supported)
    Best regards
    Michel
    sqlb_fr.zip

    @SafaAlfulaij
    Copy link
    Contributor

    @mercury233 can you try translating some dialog strings in Qt in the new file architecture (where qt.ts is just calling qtbase and others), perhaps that's the problem? If that is you can just migrate the translations from qt_zh to a new qtbase_zh and that's it.

    Other thing might be locale naming? zh zh_cn zh_tw?

    @justinclift
    Copy link
    Member

    @mvt91 Awesome. 😄

    Just to double check, that's based on the v3.12.x branch yeah, not the master branch?

    @mvt91
    Copy link
    Contributor

    mvt91 commented Jun 10, 2020

    Hi Justin,

    I got the file here :
    https://github.com/sqlitebrowser/sqlitebrowser
    Src/translation Branch Master.
    I'll check with the branch 3.12.x.

    @mvt91
    Copy link
    Contributor

    mvt91 commented Jun 10, 2020

    Hi Justin, (double message sorry)
    I lost the previous message.
    I did a mistake, I used the master branch.
    I'm translating the 3.12.x now. I'll send it in a few minutes

    @mvt91
    Copy link
    Contributor

    mvt91 commented Jun 10, 2020

    I always have an error with qt linguist 5.13.2 on that sentence :
    "Select the action to apply to the dropped file(s).
    Note: only 'Import' will process more than one file."
    I get this error :
    Translation does not contain the necessary %n/%Ln place marker.
    I suppose it doesn't matter
    Here is the 3.12.x file (zipped)
    3.12.x sqlb_fr.zip

    @mercury233
    Copy link
    Contributor

    @SafaAlfulaij I tried to set up a qt build env but failed.

    @justinclift
    Copy link
    Member

    justinclift commented Jun 11, 2020

    @mvt91 Not sure about that error. Looking at the .ts file, I think the error is mistaken. It seems to be thinking the source string has placeholders in it - which it doesn't. As you say, it probably doesn't matter. Hopefully. 😄

    For the .zip files, I just applied the first one to the master branch as that'll improve the translation there. Then applied the new .zip file to the v3.12.x branch. It all seems to be happy, so Well Done. Thanks heaps. 😄

    @mvt91
    Copy link
    Contributor

    mvt91 commented Jun 11, 2020 via email

    @justinclift
    Copy link
    Member

    @mvt91 No worries. 😄

    @mvt91
    Copy link
    Contributor

    mvt91 commented Jun 11, 2020 via email

    @MKleusberg
    Copy link
    Member

    Closing this as version 3.12 is finally released 😄

    @justinclift
    Copy link
    Member

    Good point. 😄

    Thanks heaps to everyone for the translations. The approach this time around (initial translations done, then a final "touch up" of the translations for the release candidate) seems to work out well.

    We should probably do the same thing again next time. 😄

    @MKleusberg MKleusberg unpinned this issue Jul 8, 2020
    mgrojo added a commit that referenced this issue Jul 18, 2020
    Complete translation and some improvements:
    - Fix warnings raised by Linguist
    - Avoid Title Case in Spanish
    
    Issue #2124
    
    Cherry-picked from v3.12.x branch.
    
    # Conflicts:
    #	src/translations/sqlb_es_ES.ts
    mgrojo added a commit that referenced this issue Jul 18, 2020
    Complete translation and some improvements:
    - Fix warnings raised by Linguist
    - Avoid Title Case in Spanish
    
    Issue #2124
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging a pull request may close this issue.