-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort arrows are wrong direction #231
Comments
I'll check this out tonight too. 😄 |
Interesting. What data type is the parent_list_id field defined with there? |
INT = short for INTEGER it's written full in 'list_id' to make it (synonym) of ROWID |
The arrow shows the order you can change the current one to so the opposite of what is the "status quo" |
When the user clicks on a header, call the sort function from QTableView and let it call the model's sort function. This allows the model and the view to be in sync about the sorting direction and we don't get upside-down arrows. See issue #231.
Ok, I think I got this fixed. |
Awesome @Samir-Aguiar. 😁 Just tried out the behaviour for this before-vs-after, and yeah, you guys are right. Here's a sort showing the wrong order (from the commit right before this one): @harrisrap Would you have a few minutes to try out the nightly build (tomorrow), and let us know if that works properly for you? 😄 |
@harrisrap ping? 😄 |
Sorry, I don’t see how to install the nightly build. Instructions please? |
No worries. 😄 1. Remove the existing DB4S / SQLite Browser application from your /Applications list. 2. Grab the .dmg here: http://mirror.salasaga.org/sqlitebrowser/nightly/sqlitebrowser_20150325.dmg 3. Open that dmg file (double click on it in Finder), then drag-n-drop the sqlitebrowser.app file to your /Applications folder. In theory, that should install the latest nightly build. If it doesn't for some reason, let us know. 😄 |
Eureka! You did it. Sort arrows are working perfectly now. Nice work |
Awesome. You've nailed another one perfectly @Samir-Aguiar. 😁 @harrisrap Thank you very much for reporting the problem, and verifying the fix. It really helps. 😄 |
The arrows in the column headings to indicate sort direction are incorrect. They are the opposite of what they should be. An upward facing arrow means the sort is from smaller to bigger (or alphabetic). A downward facing arrow means the sort is from bigger to smaller (or reverse alphabetic).
Take a look at the arrows in the column headers of folders on a PC or a Mac, or in Outlook, or any other common software that allows sorting by columns, and you will see they are using them the way I am describing, which is the opposite of how you are.
The text was updated successfully, but these errors were encountered: