tests: fix QCoreApplication parameters #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The argument count (first parameter) is a reference, and thus must be kept alive for the whole lifetime of the QCoreApplication instance, as also the Qt apidocs say. Also properly create a "string array" for the actual args, instead of badly casting a string to that. This fixes sporadic crashes in this test.
MKleusberg
added
the
bug
MKleusberg
added a commit
that referenced
this pull request
Jan 17, 2015
tests: fix QCoreApplication parameters
|
Thank you very much for that pull request! Nice work tracking that error messages down to these lines of code 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument count (first parameter) is a reference, and thus must be kept alive for the whole lifetime of the QCoreApplication instance, as also the Qt apidocs say.
Also properly create a "string array" for the actual args, instead of badly casting a string to that.
This fixes sporadic crashes in this test, for example as seen for some architectures in the Debian build of 3.4.0: https://buildd.debian.org/status/logs.php?pkg=sqlitebrowser&ver=3.4.0-1 & http://buildd.debian-ports.org/status/logs.php?pkg=sqlitebrowser&ver=3.4.0-1 (click on texts in the "Result" column to see the logs).