Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion - Separate Project Responsibilities #39

Closed
fulviocanducci opened this issue Dec 17, 2017 · 2 comments
Closed

Suggestion - Separate Project Responsibilities #39

fulviocanducci opened this issue Dec 17, 2017 · 2 comments

Comments

@fulviocanducci
Copy link

fulviocanducci commented Dec 17, 2017

Separate Project Responsibilities

I was looking at your new code and realized that now has a file named Query.Execute, it would not be better to make a project and use SqlKata only to generate SQL, for me it is mixing the project, that is, each project makes one one thing generates SQL the other uses SQL to write to the bank and so on?

File: https://github.com/sqlkata/querybuilder/blob/query_execution/QueryBuilder/Query.Execute.cs

I'm saying this because of AsInert and Insert and so on because if not your class that generates SQL is also resolving the Bank's share would the responsibility increase?

Comments

@fulviocanducci fulviocanducci changed the title Suggestion Suggestion - Separate Project Responsibilities Dec 17, 2017
@ahmad-moussawi
Copy link
Contributor

@fulviocanducci thanks for your feedback, yes I agree, this was the feedback of @ceastwood and @csantero also, for this reason the branch was not merged and I will cancel it.

@fulviocanducci
Copy link
Author

@ahmad-moussawi tkanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants