Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lights save -> catch not fired when invalid attribute has been set #72

Closed
WeeJeWel opened this issue Dec 23, 2016 · 2 comments
Closed

Comments

@WeeJeWel
Copy link

Please see the following example:

client.lights.getById(1).then(light => {

    // assuming this Light is a non-color light, e.g. Hue White
    light.effect = 'colorloop';
    
    client.lights.save( light )
    	.then( result => {
	    	// never called
    	})
    	.catch( result => {
	    	// never called
    	})
})

When an invalid property has been set, neither promise callbacks return.

@sqmk
Copy link
Owner

sqmk commented Dec 24, 2016

I was not able to reproduce this. Can you make sure there isn't some other issue? For example, the light you are requesting exists by id?

@WeeJeWel
Copy link
Author

Yes, the ID is correct. I'll investigate later if I can reproduce it consistently over a few days.

@sqmk sqmk closed this as completed Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants