This repository has been archived by the owner on Nov 2, 2023. It is now read-only.
agent: add url query and form parameters to the request record #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2019 17:53
Add URL query and post parameters from the request to the request record send to the backend. It allows for example to show them in the attack log page of the dashboard. PII-scrubbing is upcoming.
Merged
Julio-Guerra
pushed a commit
that referenced
this pull request
Dec 19, 2019
New Features: - Request parameters such as query or post parameters are now added in the attack events and shown in the attack logs and in the event explorer pages of our dashboard. (#84) - PII scrubbing is now performed on every event sent to Sqreen, as documented on https://docs.sqreen.com/guides/how-sqreen-works/#pii-scrubbing. (#86) Fixes: - Add PII scrubbing to the WAF logs that may include data from the request. (#87) Internal Changes: - The In-App WAF has been intensively optimized so that large requests can no longer impact its execution time. (#83)
Julio-Guerra
pushed a commit
that referenced
this pull request
Dec 19, 2019
New Features: - Request parameters such as query or post parameters are now added in the attack events and shown in the attack logs and in the event explorer pages of our dashboard. (#84) - PII scrubbing is now performed on every event sent to Sqreen, as documented on https://docs.sqreen.com/guides/how-sqreen-works/#pii-scrubbing. (#86) Fixes: - Add PII scrubbing to the WAF logs that may include data from the request. (#87) Internal Changes: - The In-App WAF has been intensively optimized so that large requests can no longer impact its execution time. (#83)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to display it in the dashboard but also have them it in the event explorer, add the request parameters to the request record.
For now we only add URL query and form parameters taken from the
http.Requestas the handler left them. So if the handler don't parse them, they will benil.This patch also reworks the request record payload creation into smaller sub-methods, one for each field.