Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for just a link instead of a img.shields.io image #320

Closed
pickypg opened this issue Mar 21, 2022 · 1 comment · Fixed by #328
Closed

Allow for just a link instead of a img.shields.io image #320

pickypg opened this issue Mar 21, 2022 · 1 comment · Fixed by #328

Comments

@pickypg
Copy link

pickypg commented Mar 21, 2022

https://github.com/sqren/backport/blob/c83e73a4db5fd84218bf72efa9a39ea8fd78bda8/src/lib/github/v3/createStatusComment.ts#L134

img.shields.io assumes a public repository. When using this for a private repository, it would be nice if I could provide a flag (for the GitHub action) to just provide a link to the PR.

image
@sorenlouv
Copy link
Owner

Hey @pickypg

Thanks for making me aware of this. Instead of making this configurable I prefer to just disable the shields for private repos. WDYT of that?

@sorenlouv sorenlouv mentioned this issue Apr 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: only show shield.io badge for public repos sorenlouv/backport
2 participants
@sorenlouv @pickypg