Fix issue with enabling auto merging for PRs #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenlouv
changed the title
sorenlouv
commented
Feb 16, 2021
| @@ -79,6 +80,11 @@ export async function cherrypickAndCreateTargetPullRequest({ | |||
| ); | |||
| } | |||
|
|
|||
| // make PR auto mergable | |||
| if (options.autoMerge) { | |||
| await enablePullRequestAutoMerge(options, targetPullRequest.number); | |||
There was a problem hiding this comment.
@brianseeders The problem was that you were using options.pullNumber which is the pull number of the source PR (the one that was already merged in). We need the target pull request number.
There was a problem hiding this comment.
I might rename options.pullNumber to option.sourcePullNumber to make this more clear.
There was a problem hiding this comment.
Oh my gosh, that's such a silly error on my part. Thanks for investigating.
There was a problem hiding this comment.
No worries. Thanks for landing this in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @brianseeders