This repository has been archived by the owner on Feb 17, 2020. It is now read-only.
SQ-27/Settings Part 4: licences ⚖️ #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't be scared by the number of lines changed, a lot of it is just the licences' text :) |
quiro91
reviewed
Mar 29, 2017
| protected void onStart() { | ||
| super.onStart(); | ||
|
|
||
| licensesList.setAdapter(new LibrariesAdapter(this)); |
There was a problem hiding this comment.
just asking: why are we creating the LibrariesAdapter every time the Activity is started? This is a fixed list which is never going to change at runtime so wouldn't it be better to set it in the onCreate ? Same for the LayoutManager and the ItemDecorator
There was a problem hiding this comment.
Yep that's actually a bug, I created onStart by mistake and didn't notice. Will fix asap.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #27 by implementing the last bit, the licences screen. As a side note I realised we don't need Android-Apt as since the Android Gradle Plugin 2.2 there is a built-in annotation processor, so I switched to that one and removed one dependency.
TODO:
FOSS licencesAbout screenUse CoordinatorLayout in settingsPhoto borderObtain cover photodefo not worth it