Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the CI setup and build #624

Merged
merged 11 commits into from Mar 31, 2019

Conversation

Projects
None yet
2 participants
@rock3r
Copy link
Collaborator

commented Mar 30, 2019

Problem

  • We're running unit tests twice on the CI for no good reason
  • FOSSA is shite
  • We're running unit tests and Lint as part of the pre-push hook
  • We're using an outdated Android CI image
  • We're using an outdated Gradle version
  • We have some fuckups in the Detekt setup

Solution

  • Make the unit tests only run once on the CI
  • Dump FOSSA
  • Only run Detekt and ktlint in the hook
  • Use the stable CI Docker image
  • Update Gradle
  • Fix the Detekt setup

Paired with

Nobody

rock3r added some commits Mar 30, 2019

Rip out FOSSA as it's junk
Not only it fails every other time we run it, it's super slow and really
is not trustworthy (false positives and false negatives are too many)

@fourlastor fourlastor merged commit 67f1f0d into develop Mar 31, 2019

4 checks passed

ci/circleci: checkout Your tests passed on CircleCI!
Details
ci/circleci: prepare_for_checks Your tests passed on CircleCI!
Details
ci/circleci: static_analysis Your tests passed on CircleCI!
Details
ci/circleci: tests Your tests passed on CircleCI!
Details

@fourlastor fourlastor deleted the ci-tweaks branch Mar 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.