Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtered highlight errors in log stores to only recent errors #130

Open
wants to merge 2 commits into
base: entin/highlights-summary
Choose a base branch
from

Conversation

NickEntin
Copy link
Collaborator

The highlighted errors can often contain red herrings in the form of old errors that aren't relevant to the issue that was seen just prior to filing the bug report. While some errors can have downstream effects much later, I've found that more often than not an older error message is unrelated and simply adds noise.

This filters out error messages that are older than 1 hour from the highlighted errors. The time interval is configurable, so developers can adjust as appropriate for their app's behavior.

The highlighted errors can often contain red herrings in the form of old errors that aren't relevant to the issue that was seen just prior to filing the bug report. While some errors can have downstream effects much later, I've found that more often than not an older error message is unrelated and simply adds noise.

This filters out error messages that are older than 1 hour from the highlighted errors. The time interval is configurable, so developers can adjust as appropriate for their app's behavior.
@NickEntin NickEntin marked this pull request as ready for review September 18, 2021 00:34
Copy link
Collaborator

@sethfri sethfri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I wonder if 30 min might make even more sense as a default. Probably fine either way

@NickEntin
Copy link
Collaborator Author

I wonder if 30 min might make even more sense as a default

I'm fine with 30 minutes as the default. 👍

@NickEntin NickEntin force-pushed the entin/highlights-summary branch 3 times, most recently from 67020d5 to ea60180 Compare December 22, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants