Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stepToWaitForSwipeableViewWithAccessibilityLabel #30

Closed
rforte opened this issue Jul 21, 2011 · 14 comments
Closed

stepToWaitForSwipeableViewWithAccessibilityLabel #30

rforte opened this issue Jul 21, 2011 · 14 comments

Comments

@rforte
Copy link

rforte commented Jul 21, 2011

Before I start looking into adding this, is there a technical reason that this wouldn't work? The use case I'm thinking about is UITableView where you swipe a cell to bring up 'Delete'.

@percysnoodle
Copy link
Contributor

I would certainly find a stepToSwipeViewWithAccessibilityLabel:inDirection: method useful.

@dineshRajpoot
Copy link

me too agree with sgbkgb.
stepToSwipeViewWithAccessibilityLabel:inDirection: method would definitely help us.

@moredip
Copy link
Contributor

moredip commented Dec 9, 2011

I'm not sure that swiping works with KIF as it stands today. A while ago I tested using KIF to trigger gesture recognizers and also to do swipe-to-delete on table rows, but I couldn't get it to work. There are more details in this thread on the mailing list.

@jterhorst
Copy link

I think moredip is correct - KIF doesn't really have the ability to trigger swipes and gestures yet. It works for drawing points (like for a signature or doodle in a view), but UIGestureRecognizers for swipes don't respond, such as for pull-to-refresh or paging through a UIScrollView. I've tried "tricking" it with different kinds of taps and actions, but no luck.

@moredip
Copy link
Contributor

moredip commented Dec 10, 2011

If anyone is interested in improving the gesture support in KIF, please ask on the Frank mailing list. We have taken several runs at improving our own support for gesture simulation, and could probably help you avoid some pitfalls.

@ghost
Copy link

ghost commented Jan 20, 2012

I've been taking a look into this. With the help of some of kra's old posts on the Frank mailing list, I think I've got it working. I'll have a bit more of a play around after the weekend and confirm.

@anthonyherron
Copy link

@lawrence-forooghian any luck with this Lawrence?

@ghost
Copy link

ghost commented Jan 31, 2012

@anthonyherron Yes, sorry for not replying as I said I would. I did some more testing and it does seem to be working. I'll be submitting a pull request once my employers have given me permission to sign the Square CLA, but unfortunately I can't give a promise for when that will be.

@anthonyherron
Copy link

@lawrence-forooghian Ace news, I did check out your fork to see how you implemented it but your "KIFTestStep+Gestures.h" file +m was empty, maybe on purpose. Thanks anyway.

@intmainvoid
Copy link

I can at verify that at least swiping on UITableViews works nicely with Lawrence's fix. Nice work.

@memmons
Copy link

memmons commented Mar 13, 2012

@kettusilmat What fix are you referring to? As far as I can tell, @lawrence-forooghian 's repo doesn't have any changes to KIFTestStep. Someone mentioned a KIFTestStep+Gestures.h file as well, which isn't in his repo either.

@intmainvoid
Copy link

@memmons Have a look at this commit on the swipe branch. You can see he has made changes to KIFTestStep here (not on master which is why you might have missed it).

@ghost
Copy link

ghost commented Apr 10, 2012

I've finally got permission to sign the CLA, so I've opened a pull request.

@aleb
Copy link

aleb commented Oct 5, 2012

Please close this issue, the pull request has been merged.

It fails for iPad screens, though. Would be nice to have #135 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants