Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test vectors for cached data #58

Closed
jqmp opened this issue Nov 13, 2019 · 0 comments · Fixed by #86
Closed

Add regression test vectors for cached data #58

jqmp opened this issue Nov 13, 2019 · 0 comments · Fixed by #86
Labels
enhancement New feature or request

Comments

@jqmp
Copy link
Collaborator

jqmp commented Nov 13, 2019

When we change Bionic's caching code, we run the risk of making backwards-incompatible changes, creating a situation where the current version of Bionic can't load cached data from older versions. A recent example of this is the bug fixed here. Our current tests can't catch these errors because they both save and load data using the latest code.

One way to catch these errors automatically is to write a set of tests that attempt to load data from a fixed, checked-in set of cached files. This will force us to explicitly update these files when we make a non-backwards-compatible change. (If we do make such a change, we should bump the CACHE_SCHEMA_VERSION constant -- to avoid trying to load the old files at all -- and the minor version number.)

@jqmp jqmp added the enhancement New feature or request label Feb 6, 2020
@namanjain namanjain linked a pull request Mar 3, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants