Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist backstack entries viewstate gracefully #68

Closed
wants to merge 4 commits into from
Closed

Persist backstack entries viewstate gracefully #68

wants to merge 4 commits into from

Conversation

almozavr
Copy link

See #67 for details

Aleksey Malevaniy added 4 commits March 31, 2015 18:07
Persist current backstack entry viewstate
99275a6 
Entry's viewstate should be persisted not only when path is replaced with another path,
but also when on-save-instance is occurred, so topmost backstack entry has it's own viewstate
identical to underlying view has. (partly fixes square#67)
Save backstack with it's viewstates
c3f1783 
When saving getBackstackToSave filters backstack entries without path's NotPersist annotation,
but also should not ignore current entries viewstates and copy 'em gracefully.
Fully fixes square#67
Remove saveViewState for Backstack Entry as it occurs internally
d0aeb8f
Check if current entry is persistable before save viewstate
8d5d023
@rjrjr
Copy link
Collaborator

rjrjr commented Apr 2, 2015

Thanks for the bug report and the PR. You've probably noticed that the API is being updated, and I don't think what you've proposed here is quite what @loganj has in mind. But we'll make sure to cover this case.

@rjrjr rjrjr closed this Apr 2, 2015
@almozavr
Copy link
Author

almozavr commented Apr 2, 2015

No sure, but #72 seems to me make no change at problem of not persisting
ViewState. I’d like to use newest api but don’t want to strugle for
ViewState problem. So let me update pr to latest api changes, and maybe
@loganj could join discussion? Would be great!

On Thu, Apr 2, 2015 at 6:58 PM rjrjr notifications@github.com wrote:

Thanks for the bug report and the PR. You've probably noticed that the API
is being updated, and I don't think what you've proposed here is quite what
@loganj https://github.com/loganj has in mind. But we'll make sure to
cover this case.

—
Reply to this email directly or view it on GitHub
#68 (comment).

@almozavr almozavr deleted the persist_current_path_viewstate branch January 27, 2016 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@almozavr @rjrjr