Add a "nopkcs11" build tag #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows opting out of PKCS11 (to avoid needing libltdl), but with CGO still enabled so certstore is usable ~ CGO_ENABLED=1 go build -tags "nopkcs11 certstore" ~ otool -L ./ghostunnel ./ghostunnel: /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1570.15.0) /System/Library/Frameworks/Security.framework/Versions/A/Security (compatibility version 1.0.0, current version 58286.251.4) /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.250.1)
csstaub
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows opting out of PKCS11 (to avoid needing libltdl), but with CGO still
enabled so certstore is usable
It's a negative so that PKCS11 is built by default. Maybe we don't need PKCS11 by default, and can make it a build time option like certstore?
~ CGO_ENABLED=1 go build -tags "nopkcs11 certstore"
~ otool -L ./ghostunnel
./ghostunnel:
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1570.15.0)
/System/Library/Frameworks/Security.framework/Versions/A/Security (compatibility version 1.0.0, current version 58286.251.4)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.250.1)