Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Cmd-T with Ctrl-P #41

Merged
merged 4 commits into from
Aug 31, 2013
Merged

Replace Cmd-T with Ctrl-P #41

merged 4 commits into from
Aug 31, 2013

Conversation

strongriley
Copy link
Collaborator

I would suggest replacing Command-T with Control-P. Control-P performs the same task but is in my experience faster, and is implemented in pure vimscript so does not depend on any compilation steps during install or Ruby bindings.

https://github.com/kien/ctrlp.vim

@sebdah
Copy link
Contributor

sebdah commented Aug 30, 2013

+1

@rudle
Copy link
Collaborator

rudle commented Aug 30, 2013

I'd be happy to merge such a pull

@MarkVillacampa
Copy link

Command-T seems to be causing many problems to people (including me) using rvm or rbenv to manage ruby. See #23 and #24.

If Command-P is feature similar to Command-T, I +1 the switch.

@strongriley
Copy link
Collaborator

Working on this right now. Too many people are having issues with Command-T.

@strongriley
Copy link
Collaborator

@rudle ...And here it is 😄
edit: And @steckel

@strongriley
Copy link
Collaborator

We may want to add a build step that automatically purges old git submodules, otherwise people experiencing the SegFault have to manually rm -rf vim/bundle/command-t

@minuteman3
Copy link
Author

I would advocate abandoning the submodule orientated packaging of plugins and switching to Vundle as per my suggestion in #45. It would eliminate these sort of complications in the future if new packages are added or old packages are removed, and would be easier for users to keep their plugins up to date.

@minuteman3
Copy link
Author

Also, thanks for taking care of this @strongriley. I probably wouldn't have had an opportunity to get around to it this weekend.

@strongriley
Copy link
Collaborator

no prob! Maybe just get it replaced in the short-term using Pathogen and submodules to stop all the pain, then we can talk about moving to Vundle in the future?

@ghost
Copy link

ghost commented Aug 30, 2013

+1

Also, I think we should definitely clear the cache when vim exits - imagine
switching branches, opening vim and not finding your files.
@rudle
Copy link
Collaborator

rudle commented Aug 30, 2013

@strongriley please confirm the new hotness, and then merge this bad dog.

nmap <leader>d :NERDTreeToggle<CR>
nmap <leader>f :NERDTreeFind<CR>
nmap <leader>t :CommandT<CR>
nmap <leader>T :CommandTFlush<CR>:CommandT<CR>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is still nice to have when you add new files.

@strongriley
Copy link
Collaborator

LGTM except I still like the ,T with refresh.

@rudle
Copy link
Collaborator

rudle commented Aug 31, 2013

@strongriley take a look now. I was under the impression that ctrlp wasn't caching at all, and it seemed fast enough to me that we didn't need to cache and thus didn't need the binding.

@strongriley
Copy link
Collaborator

Thanks @rudle. From what I can tell, it caches within the same session, which needs to be cleared if files are added or deleted. Merging.

strongriley added a commit that referenced this pull request Aug 31, 2013
@strongriley strongriley merged commit eb583ac into master Aug 31, 2013
@strongriley strongriley mentioned this pull request Aug 31, 2013
@rudle rudle deleted the riley/ctrlp branch September 1, 2013 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants