-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
okhttp3 3.12.x parse Part BUG #4564
Comments
Related to #3876 Should confirm we got all cases. |
Is it possible to backport this to 3.12.x? |
Closes: square#4564 (cherry picked from commit 94c38da)
@valepakh pull request? |
@swankjesse my application support android4.x but this bug very critical |
@Movill-Tony-p awesome. Please do. |
@swankjesse I actually filed pull request #4618 a while back, it works ok, just doesn't pass the build due to the java changes. |
Thanks so much for this backport, @valepakh, and for the merge, @swankjesse. You're helping folks collect data in challenging environments (and languages with Unicode characters). 🎉 |
Good bug reports include a failing test! Writing a test helps you to isolate and describe the problem, and it helps us to fix it fast. Bug reports without a failing test or reproduction steps are likely to be closed.
Here’s an example test to get you started.
https://gist.github.com/swankjesse/981fcae102f513eb13ed
Version :
3.12.x
Error description :
When the
MultipartBody.Part.createFormData(String name, @Nullable String filename, RequestBody body)
method is called, if the file name contains Chinese, an IllegalArgumentException will be thrown to locate the calling chain:The final code is as follows:
As shown above, this code does not handle Chinese correctly.
The text was updated successfully, but these errors were encountered: