Allow users to set UTF-8 characters in Multipart Parts when they use addFormDataPart(...) #4576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use addUnsafeNonAscii(...) that was previously added to Headers.Builder[1]. [1] square#4296
…addFormDataPart(...) Currently the user is not allowed to set Non-ASCII characters to `filename` when calling `addFormDataPart(...)`. When `addFormDataPart(...)` calls `Part.createFormData(...)`, `Headers.of(...)`, which rejects Non-ASCII characters, is executed. By employing `Headers.Builder` with 'addUnsafeNonAscii(...)' when calling `Part.createFormData(...)`, users can set Non-ASCII characters.
monkey-mas
force-pushed
the
allow-users-to-use-utf8-in-multipart-parts-header
branch
from
8b2dae3
to
fdc204a
Compare
yschimke
reviewed
Jan 27, 2019
| "Content-Disposition", "file; filename=\"file2.gif\"", | ||
| "Content-Transfer-Encoding", "binary"), | ||
| new Headers.Builder() | ||
| .addUnsafeNonAscii("Content-Disposition", "file; filename=\"file2€.gif\"") |
There was a problem hiding this comment.
Can you move this out into a separate targeted test and leave the existing test unchanged? The new test can be shorter and just focus on length and filename encoding.
There was a problem hiding this comment.
Yeah, I undid the change. Do you think I can even remove expected to do assertEquals(expected, buffer.readUtf8())?
|
Thanks! Obsoleted by #4584 |
monkey-mas
deleted the
allow-users-to-use-utf8-in-multipart-parts-header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4564
Currently the user is not allowed to set Non-ASCII characters to
filenamewhen calling addFormDataPart(...). WhenaddFormDataPart(...)calls Part.createFormData(...), Headers.of(...), which rejects Non-ASCII characters, is executed. By employingHeaders.Builderwith addUnsafeNonAscii(...) when callingPart.createFormData(...), users can set Non-ASCII characters.