Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A mechanism for adding non-ASCII headers #4296

Merged
merged 3 commits into from
Sep 29, 2018
Merged

A mechanism for adding non-ASCII headers #4296

merged 3 commits into from
Sep 29, 2018

Conversation

amirlivneh
Copy link
Collaborator

As suggested in #4283 (comment).

yschimke
yschimke approved these changes Sep 29, 2018
View reviewed changes
Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swankjesse
Copy link
Member

It's my preference that we only expose this via the builder, named addUnsafeNonAscii(). For this we should still require that header names pass strict validation.

@swankjesse swankjesse merged commit 0ebaef2 into square:master Sep 29, 2018
@swankjesse
Copy link
Member

Thanks!

@amirlivneh amirlivneh deleted the non-ascii-headers branch September 29, 2018 21:40
@swankjesse swankjesse mentioned this pull request Nov 3, 2018
Closed
@elliscwc elliscwc mentioned this pull request Dec 5, 2018
Closed
@sxci
Copy link

sxci commented Dec 11, 2018

https://github.com/square/okhttp/blob/parent-3.12.0/okhttp/src/main/java/okhttp3/MultipartBody.java#L259
it looks like doesnot allow utf8 headers, Header.of check strict validation.

monkey-mas added a commit to monkey-mas/okhttp that referenced this pull request Jan 27, 2019
@monkey-mas
Use addUnsafeNonAscii(...) in MultipartBodyTest
1bb7113 
Use addUnsafeNonAscii(...) that was previously added to Headers.Builder[1].

[1] square#4296
monkey-mas added a commit to monkey-mas/okhttp that referenced this pull request Jan 27, 2019
@monkey-mas
Use addUnsafeNonAscii(...) in MultipartBodyTest
a8cde0e 
Use addUnsafeNonAscii(...) that was previously added to Headers.Builder[1].

[1] square#4296
@robertying robertying mentioned this pull request May 17, 2021
Closed
@yschimke yschimke mentioned this pull request May 15, 2022
Closed
@robertying robertying mentioned this pull request Oct 25, 2022
Closed
@adamgorMSFT adamgorMSFT mentioned this pull request Feb 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swankjesse swankjesse swankjesse approved these changes

@yschimke yschimke yschimke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amirlivneh @swankjesse @sxci @yschimke