Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headers.of() doesn’t enforce ASCII-only #4283

Closed
swankjesse opened this issue Sep 22, 2018 · 2 comments
Closed

Headers.of() doesn’t enforce ASCII-only #4283

swankjesse opened this issue Sep 22, 2018 · 2 comments
Labels
bug Bug in existing code

Comments

@swankjesse
Copy link
Collaborator

Needs to call checkNameAndValue to confirm that invalid characters can’t sneak through.
@swankjesse swankjesse mentioned this issue Sep 22, 2018
Closed
@swankjesse
Copy link
Collaborator Author

And maybe a proper supported mechanism to add non-ASCII headers because sometimes people need that.

@yschimke yschimke added bug Bug in existing code starter labels Sep 22, 2018
@NightlyNexus NightlyNexus mentioned this issue Sep 24, 2018
Merged
@yschimke yschimke removed the starter label Sep 27, 2018
@amirlivneh amirlivneh mentioned this issue Sep 29, 2018
Merged
@amirlivneh
Copy link
Collaborator

I think this issue can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug in existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@swankjesse @yschimke @amirlivneh