Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect decorators in raw pin operation functions in the JLink class #87

Open
sgmne opened this issue Feb 28, 2021 · 2 comments
Open

Comments

@sgmne
Copy link

sgmne commented Feb 28, 2021

The functions in JLink class

set_reset_pin_high(self):
set_reset_pin_low(self):
set_tck_pin_high(self):
set_tck_pin_low(self):
set_tdi_pin_high(self):
set_tdi_pin_low(self):
set_tms_pin_high(self):
set_tms_pin_low(self):
set_trst_pin_high(self):
set_trst_pin_low(self):

are raw operations and hence should be @open_required, not @connection_required.

@hkpeprah
Copy link
Contributor

hkpeprah commented Mar 1, 2021

Thanks for bringing this up, this is definitely an oversight. If you wish to submit a patch to address this, I can review and merge it in, otherwise I will open up one when I find time available.

@sgmne
Copy link
Author

sgmne commented Mar 1, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants