-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a board selection screen to the Dungeon sample. #874
Conversation
5336c42
to
3d2eb7b
Compare
3d2eb7b
to
19b7b4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So exciting!
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/BoardLoader.kt
Show resolved
Hide resolved
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/BoardsListLayoutRunner.kt
Outdated
Show resolved
Hide resolved
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/BoardsListLayoutRunner.kt
Outdated
Show resolved
Hide resolved
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/BoardsListLayoutRunner.kt
Outdated
Show resolved
Hide resolved
kotlin/samples/dungeon/common/src/main/java/com/squareup/sample/dungeon/board/Board.kt
Show resolved
Hide resolved
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/BoardsListLayoutRunner.kt
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,132 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a new file, but was just renamed from DungeonAppWorkflow
.
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/BoardsListLayoutRunner.kt
Outdated
Show resolved
Hide resolved
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/BoardsListLayoutRunner.kt
Outdated
Show resolved
Hide resolved
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/LoadingBinding.kt
Show resolved
Hide resolved
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/LoadingBinding.kt
Outdated
Show resolved
Hide resolved
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/GameSessionWorkflow.kt
Outdated
Show resolved
Hide resolved
Need to add a "New Board" button to the Game Over dialog. |
I broke parser tests, also need to write more. |
741b2db
to
6b72575
Compare
Fixed parser tests, added tests for metadata parsing, and addressed all outstanding comments. |
Going to do this separately in #891. |
This change does a few things:
GameSessionWorkflow
(just renamed fromDungeonAppWorkflow
).WorkflowViewStub
to display a preview of each board in the list, automatically re-using the same code that the actual game screen uses to render the board while playing.