Add a board selection screen to the Dungeon sample. #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-klippenstein
force-pushed
the
zachklipp/dungeon-map-chooser
branch
from
5336c42
to
3d2eb7b
Compare
zach-klippenstein
force-pushed
the
zachklipp/dungeon-map-chooser
branch
from
3d2eb7b
to
19b7b4a
Compare
rjrjr
approved these changes
Jan 14, 2020
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/BoardLoader.kt
Show resolved
Hide resolved
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/BoardsListLayoutRunner.kt
Outdated
Show resolved
Hide resolved
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/BoardsListLayoutRunner.kt
Outdated
Show resolved
Hide resolved
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/BoardsListLayoutRunner.kt
Outdated
Show resolved
Hide resolved
kotlin/samples/dungeon/common/src/main/java/com/squareup/sample/dungeon/board/Board.kt
Show resolved
Hide resolved
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/BoardsListLayoutRunner.kt
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,132 @@ | |||
| /* | |||
There was a problem hiding this comment.
This looks like a new file, but was just renamed from DungeonAppWorkflow.
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/BoardsListLayoutRunner.kt
Outdated
Show resolved
Hide resolved
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/BoardsListLayoutRunner.kt
Outdated
Show resolved
Hide resolved
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/LoadingBinding.kt
Show resolved
Hide resolved
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/LoadingBinding.kt
Outdated
Show resolved
Hide resolved
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/GameSessionWorkflow.kt
Outdated
Show resolved
Hide resolved
|
Need to add a "New Board" button to the Game Over dialog. |
|
I broke parser tests, also need to write more. |
kirillzh
approved these changes
Jan 14, 2020
zach-klippenstein
force-pushed
the
zachklipp/dungeon-map-chooser
branch
from
741b2db
to
6b72575
Compare
|
Fixed parser tests, added tests for metadata parsing, and addressed all outstanding comments. |
Going to do this separately in #891. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does a few things:
GameSessionWorkflow(just renamed fromDungeonAppWorkflow).WorkflowViewStubto display a preview of each board in the list, automatically re-using the same code that the actual game screen uses to render the board while playing.