Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back button support to Dungeon sample game screen. #873

Closed
wants to merge 3 commits into from
Closed

Add back button support to Dungeon sample game screen. #873

wants to merge 3 commits into from

Conversation

zach-klippenstein
Copy link
Collaborator

@zach-klippenstein zach-klippenstein commented Jan 14, 2020 •
edited
Loading

Based on #874.

@zach-klippenstein zach-klippenstein mentioned this pull request May 4, 2022
Closed
zach-klippenstein
zach-klippenstein commented Jan 14, 2020
View reviewed changes
kotlin/samples/dungeon/app/src/main/java/com/squareup/sample/dungeon/GameLayoutRunner.kt
@@ -52,6 +53,8 @@ class GameLayoutRunner(view: View) : LayoutRunner<GameRendering> {
rendering: GameRendering,
containerHints: ContainerHints
) {
view.backPressedHandler = rendering.onBackPressed
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently broken by #875.

@zach-klippenstein zach-klippenstein deleted the zachklipp/dungeon-back-support branch January 30, 2020 14:30
@zach-klippenstein zach-klippenstein added the kotlin Affects the Kotlin library. label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked kotlin Affects the Kotlin library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zach-klippenstein