Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Float is without decimals, it generates a conversion error. #78

Closed
julien-lecomte opened this issue Apr 26, 2021 · 1 comment
Closed

Comments

@julien-lecomte
Copy link
Contributor

julien-lecomte commented Apr 26, 2021

When filtering json through "jq", integer floats (0.0, 1.0, ...) are converted to integers without decimals (0, 1, ...)

This blocks the packing of the module with an error as Error: Could not convert src/ux/areas.tpl/area_technical.git.json to area_technical.git: {"type":"float","value":0}

This error could be ignorable by being tolerant and treating int as float: 0 as 0.0, etc...

@squattingmonk
Copy link
Owner

I agree this should be changed. However, the actual conversion is done by neverwinter.nim, so this issue needs to be opened there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants