Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Block placement preview #8

Closed
nco2k opened this issue Mar 26, 2024 · 10 comments
Closed

[Suggestion] Block placement preview #8

nco2k opened this issue Mar 26, 2024 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@nco2k
Copy link

nco2k commented Mar 26, 2024

i really like the "Bridge-assist block outline" feature, and would like to suggest an option to always show a block placement preview, not just when bridging. this way we could use your mod as a general purpose block placement preview mod. it should of course respect the "Only use bridge-assist while crouching" setting.

@squeeglii squeeglii added the enhancement New feature or request label Mar 26, 2024
@squeeglii
Copy link
Owner

I'm a little bit confused by this as vanilla shows an outline when bridging is not being used. Are you suggesting shifting that vanilla outline from the block you can break to the air gap where you can place?

@nco2k
Copy link
Author

nco2k commented Mar 26, 2024

yes.

currently your mod allows us to show an outline when you can bridge:
pic1

im suggesting an option to show that outline whenever you can place a block:
pic2

it shouldnt ofc remove the vanilla breaking block outline, but show yours as an addition. this could be incredibly useful at times. especially if you were up for adding another option to show a shape preview like for example when using stairs. this way we can make sure to never accidentally connect them the wrong way. but i think that might go beyond the scope of your mod. one can dream though. :D

@squeeglii
Copy link
Owner

Ahh awesome. Adding that shouldn't be too bad then. Will consider fancy outlines for a later update but a simple box will do for now.

Should be in the next update! :]

squeeglii added a commit that referenced this issue Mar 29, 2024
- Not shown when colliding with the player
- Can optionally respect crouching + bridging enabled/disabled rules
- Has its own configuration for visibility (F3 + Normal)

Signed-off-by: Will Scully <16578982+squeeglii@users.noreply.github.com>
@squeeglii
Copy link
Owner

Implemented with a few config options - it's off by default but the you can find the setting in the "Visual" category.

Will be in v2.3.0. Thanks for the suggestion!

@nco2k
Copy link
Author

nco2k commented Mar 29, 2024

wow that was fast. thanks for adding this!

there is one small cosmetic issue though. the bridging outline color (white) merges with the vanilla outline color (black) and therefor creates a new in-between color (grey) when the two outlines overlap. any chance you can fix that?

outline1
outline2

@squeeglii
Copy link
Owner

squeeglii commented Mar 29, 2024

Have you set the lines to full opacity? The colour #ffffffff should do that. Transparency will lead to blending and there's not an easy way to fix that without modifying the vanilla outline.

@nco2k
Copy link
Author

nco2k commented Mar 30, 2024

yes im using #ffffffff

squeeglii pushed a commit that referenced this issue Mar 30, 2024
Signed-off-by: Will Scully <16578982+squeeglii@users.noreply.github.com>

Change how mappings work slightly to make sources more compatible

Signed-off-by: Will Scully <16578982+squeeglii@users.noreply.github.com>

Bump version & update readme with credit for translations. Removes versions from README as they end up falling out of sync anyway.

Signed-off-by: Will Scully <16578982+squeeglii@users.noreply.github.com>

Crosshair is now hidden when bridging is disabled

Signed-off-by: Will Scully <16578982+squeeglii@users.noreply.github.com>

Implement Suggestion #8 - Non-Bridging outlines are now shown.
- Not shown when colliding with the player
- Can optionally respect crouching + bridging enabled/disabled rules
- Has its own configuration for visibility (F3 + Normal)

Signed-off-by: Will Scully <16578982+squeeglii@users.noreply.github.com>

Mexican Spanish translation

Heyy just a small translation i made, hope it helps
@squeeglii
Copy link
Owner

squeeglii commented Mar 30, 2024

Strange - it didn't look the same on my end. Are you using any mods that modify your graphics?
I've tried it on Fast, Fancy, & Fabulous on Fabric.

squeeglii added a commit that referenced this issue Mar 30, 2024
Signed-off-by: Will Scully <16578982+squeeglii@users.noreply.github.com>

Change how mappings work slightly to make sources more compatible

Signed-off-by: Will Scully <16578982+squeeglii@users.noreply.github.com>

Bump version & update readme with credit for translations. Removes versions from README as they end up falling out of sync anyway.

Signed-off-by: Will Scully <16578982+squeeglii@users.noreply.github.com>

Crosshair is now hidden when bridging is disabled

Signed-off-by: Will Scully <16578982+squeeglii@users.noreply.github.com>

Implement Suggestion #8 - Non-Bridging outlines are now shown.
- Not shown when colliding with the player
- Can optionally respect crouching + bridging enabled/disabled rules
- Has its own configuration for visibility (F3 + Normal)

Signed-off-by: Will Scully <16578982+squeeglii@users.noreply.github.com>

Mexican Spanish translation

Heyy just a small translation i made, hope it helps

Signed-off-by: Will Scully <16578982+squeeglii@users.noreply.github.com>
@squeeglii squeeglii self-assigned this Mar 30, 2024
@nco2k
Copy link
Author

nco2k commented Mar 30, 2024

okay it looks like its caused by Iris Shaders, even if no shader pack is currently being used.

i could reproduce it with just the following mods:

  • Fabric API 0.96.11+1.20.4
  • Sodium 1.20.4-0.5.8
  • Iris Shaders 1.6.17+1.20.4
  • Cloth Config API 13.0.121
  • Bridging Mod 2.3.0+1.20.4

as soon as i remove Iris Shaders, it works as intended. very strange.

@squeeglii
Copy link
Owner

squeeglii commented Mar 30, 2024

fuuuun, I love vague and mysterious graphical bugs. 💀

Will move this into a new issue. Not sure how long it'll take to fix as it's quite minor and doesn't have a clear cause, but I'll take a look either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants