-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
annotation buttons' content within admonitions are not centered #4558
Comments
Thanks for reporting. I've already poured several hours into trying to solve this problem some time ago, but from my current knowledge I think it's not generally solvable. It's definitely related to sub-pixel rounding issues, which is implemented differently in all browsers. Additionally, proportional fonts other than One idea I explored is to substitute the text ( I'm closing this as 'won't fix', but since you have a downstream project with very similar goals, I'm happy to merge a fix in upstream if you find a better way of implementing annotations. |
Thanks for getting back. My initial "hack" would be to exempt the buttons within admonitions from the smaller font in CSS. But I haven't really played with it (yet). |
You will see alignment issues in the regular font size as well, so this hack will only solve parts of the problem. |
Note that this is all fixed in Insiders, and will be merged with the annotation feature once the next funding goal is hit. We switched annotations to use icons instead of the code font, which yields a much more consistent rendering. Additionally, annotation icons can now be changed to any icon. |
Contribution guidelines
I've found a bug and checked that ...
mkdocs
orreadthedocs
themescustom_dir
,extra_javascript
andextra_css
Description
I noticed that the
+
(& rotated+
) used for the annotations' button content is a bit off center when placed within an admonition.I think this may be related to the slightly smaller font used for admonitions.
Expected behaviour
Not a huge deal, but I had expected the buttons content to align with the center of the button.
Actual behaviour
See above picture in description.
also seen in master (as of 3459540)
Steps to reproduce
see the insiders docs here
I should note that it still shows in master (as of 3459540)
Package versions
Configuration
same for this repo.
System information
The text was updated successfully, but these errors were encountered: