Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 page not built anymore? #575

Closed
kcgthb opened this issue Nov 7, 2017 · 3 comments
Closed

404 page not built anymore? #575

kcgthb opened this issue Nov 7, 2017 · 3 comments
Assignees
Labels
bug Issue reports a bug

Comments

@kcgthb
Copy link
Contributor

kcgthb commented Nov 7, 2017

Description

It looks like the 404 page template doesn't work anymore.

Expected behavior

Get the templated 404 page when accessing a non-existing URL.

Actual behavior

Get a simple 404: Not Found text, or a redirection to the generic GH pages 404 page.

Steps to reproduce the bug

Go to https://squidfunk.github.io/mkdocs-material/foo :)

Package versions

  • Python: python --version: 3.4.5
  • MkDocs: mkdocs --version: 0.17.1
  • Material: pip show mkdocs-material | grep -E ^Version: 2.0.1

Project configuration

not relevant.

System information

  • OS: Linux
  • Browser: Chrome
@max-ci
Copy link

max-ci commented Nov 7, 2017

In order to have custom 404 page on GitHub Pages you have to:

create a HTML file named 404.html or create a new Markdown file named 404.md at the root level of your GitHub Pages repository.

Source

There is no such file in gh-pages branch in this repository.

@squidfunk
Copy link
Owner

squidfunk commented Nov 7, 2017

There's in fact a config option that was forgotten to be included in the mkdocs.yml of Material. 404 pages work for all projects using the theme, e.g.:
http://facelessuser.github.io/BracketHighlighter/foo (uses 2.0.4)

I will provide a fix, so it will also work in the official docs.

@squidfunk squidfunk self-assigned this Nov 7, 2017
@squidfunk squidfunk added the bug Issue reports a bug label Nov 7, 2017
@squidfunk
Copy link
Owner

Fixed in #576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug
Projects
None yet
Development

No branches or pull requests

3 participants