Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dev]: Clean up squire_web #118

Closed
TylerBloom opened this issue Jun 22, 2023 · 0 comments
Closed

[Dev]: Clean up squire_web #118

TylerBloom opened this issue Jun 22, 2023 · 0 comments
Assignees
@fintanneff
Labels
requirement A requirement for the next major release
Milestone
SquireWeb Prototype

Comments

@TylerBloom
Copy link
Member

Unmet Need:

As the web app nears MVP, the squire_web crate needs to be cleaned up.

Solution:

The clean-up should happen in three distinct steps:

  1. Remove any global allow statements. Currently, there are two at the top of main.rs
  2. Add compiler directives to deny bad practices. The list that is used at the top of squire_lib/src/lib.rs will suffice.
  3. Run clippy on the SW
@TylerBloom TylerBloom added todo Will be resolved but work hasn't started requirement A requirement for the next major release labels Jun 22, 2023
@TylerBloom TylerBloom added this to the SquireWeb Prototype milestone Jun 22, 2023
@TylerBloom TylerBloom removed the todo Will be resolved but work hasn't started label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fintanneff fintanneff

Labels
requirement A requirement for the next major release
Projects
Squire Tournament Services
Status: Done
Milestone
SquireWeb Prototype
Development

No branches or pull requests
2 participants
@TylerBloom @fintanneff