PSR12 standard reports errors for multi-line FOR definitions

[andre-exads]

Current PSR-12 configuration on CodeSniffer treat multi-line conditions in a for loop as incorrect, but according to https://www.php-fig.org/psr/psr-12/#54-for it is allowed. Example bellow.

for (
    $i=0;
    $i<5;
    $i++
) {
    // body here
}

[jrfnl]

@andre-exads Could you share the ruleset configuration you are using ? Or at the very least, please check that your ruleset does not include both PSR2 as well as PSR12.
The PSR12 ruleset includes all relevant rules from PSR2 automatically and having both rulesets active causes conflicts as the standards are different.

[andre-exads]

I'm not using phpcs file of any kind in my project (when I tried it was an even bigger mess) I only have the following setting on VScode settings.json:

"phpcs.standard": "PSR12",

But if I run it straight from the command line I have the same result:

phpcs --standard=PSR12 /full/path/to/code/file.php 

FILE: /full/path/to/code/file.php
--------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------
 236 | ERROR | [x] Expected 1 space after first semicolon of FOR loop; newline found
 237 | ERROR | [x] Expected 1 space after second semicolon of FOR loop; newline found
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------

Time: 105ms; Memory: 8MB

I'm on Fedora Workstation 31 - php-pear-PHP-CodeSniffer-3.5.3-1.fc31.noarch

[gsherwood]

I've committed a fix for this, which will be in 3.5.4. The solution required a new ignoreNewlines property for the Squiz.ControlStructures.ForLoopDeclaration sniff, which I've documented here: https://github.com/squizlabs/PHP_CodeSniffer/wiki/Customisable-Sniff-Properties#squizcontrolstructuresforloopdeclaration

Thanks for reporting this.