Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squiz/ClosingDeclarationComment: use $data rather than composing the error message in parts #1425

Merged

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Apr 14, 2017

No description provided.

@jrfnl jrfnl force-pushed the feature/squiz-closing-declaration-error-msg branch from 3b5d3bf to b36d20b Compare April 14, 2017 18:25
@gsherwood gsherwood merged commit b36d20b into squizlabs:master Apr 20, 2017
@gsherwood
Copy link
Member

Good change. Thanks.

@jrfnl jrfnl deleted the feature/squiz-closing-declaration-error-msg branch April 20, 2017 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants