Support PHP 7.3 #2158
Merged
Support PHP 7.3 #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per https://wiki.php.net/rfc/continue_on_switch_deprecation the use of `continue` is deprecate in switch statements and should use either break or continue 2.
|
FYI: In the PHPCS 3.x |
|
Yeah I saw it was fixed in 3x, but I didn't check for when, thanks for the link/history @jrfnl |
|
Thanks. I've merged this in and fixed the two additional ones in the CSS tokenizer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://wiki.php.net/rfc/continue_on_switch_deprecation the use of
continueis deprecate in switch statements and should use either break or continue 2.