Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/Travis: validate rulesets against XSD and check code style consistency #2187

Merged
merged 3 commits into from
Oct 18, 2018

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Oct 16, 2018

Commit summary

Build: lint the XML rulesets and check for consistent code style

Notes:

  • Runs only once per build as the results are independent of the PHP version.
  • Indent is set at four spaces as per commit 232f7da .
  • I've elected to add this check to the smallest (fastest) build, so the build time will be spread more evenly.
  • Not linting the PHPCS native ruleset as it's being run anyway, so is automatically checked.

Add the XSD schema tags to the XML rulesets

Clean the XML ruleset files/consistent code style

Notes:
* Runs only once per build as the results are independent of the PHP version.
* Indent is set at four spaces as per commit 232f7da .
* I've elected to add this check to the smallest (fastest) build, so the build time will be spread more evenly.
* Not linting the PHPCS native ruleset as it's being run anyway, so is automatically checked.
@gsherwood
Copy link
Member

Thanks. You're a 💎 !

@gsherwood gsherwood added this to the 3.4.0 milestone Oct 18, 2018
@jrfnl jrfnl deleted the feature/validate-rulesets branch October 18, 2018 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants