PHP 8.0 | File::getMethodProperties(): support mixed type and union types #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No changes needed to the actual method, the return type is already handled correctly.
`array` keywords used as return types in PHP 8 union types would only be correctly changed to `T_STRING` if they were the first type in the union. Fixed now. Includes adding `T_STATIC` to the array of allowed tokens. While previously it wasn't an issue that the token was not includes in the array, it is necessary for the token to be there to support union types.
PHP 8 introduces union types. This adds support for union types to the `File::getMethodProperties()` method. Includes extensive unit tests. Ref: https://wiki.php.net/rfc/union_types_v2
jrfnl
force-pushed
the
feature/2968-getmethodproperties-support-php8-mixed-and-union-types
branch
from
faabb0e
to
dc0fe93
Compare
|
Test build which includes PR #3014 which confirms that the build for this PR would pass on PHP 8/nightly: https://travis-ci.com/github/jrfnl/PHP_CodeSniffer/jobs/360290484 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.0 will introduce a new pseudo-type
mixedas well as union types.This PR adds tests for these to the
File::getMethodProperties()method and makes minor changes to the method to allow for supporting these new type declarations.Includes a change to the PHP tokenizer to make sure that the
arraykeyword in union return types is changed toT_STRING.Refs:
👉 Important: all sniffs using this method will need to be checked to see if they use the
return_typeindex and if so, if the check being done needs to take union types into account.Partially addresses #2968