Tokenizer/PHP: bug fix in improved context sensitive keyword support #3610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in 3609, the `empty` keyword, as well as the `isset` and `unset` keywords, was not included in the list of context sensitive keyword. This is a regression compared to PHPCS 3.6.2. Fixed now, including unit tests. Note: I've now done a full comparison with the [reserved keyword list as per the PHP manual](https://www.php.net/manual/en/reserved.keywords.php). This should hopefully fix the remaining stranglers. Fixes 3609
|
Fixed in 30mins 😱 Thank you! |
|
And merged 45 minutes later, we're on a roll 🛼 |
This was referenced Jun 13, 2022
|
@jrfnl Thank you. I used the list from https://wiki.php.net/rfc/context_sensitive_lexer and it looks it was not complete... |
|
@kukulich No worries and yeah, that happens regularly with PHP RFCs (not being complete). I regularly run into that when working on PHPCompatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #3609, the
emptykeyword, as well as theissetandunsetkeywords, was not included in the list of context sensitive keyword. This is a regression compared to PHPCS 3.6.2.Fixed now, including unit tests.
Note: I've now done a full comparison with the reserved keyword list as per the PHP manual. This should hopefully fix the remaining stragglers.
Fixes #3609