Conversation
... as introduced in PHPCS 3.7.0 and updated in PHPCS 3.7.1. Upstream PR 3484 introduces a new `$contextSensitiveKeywords` tokens array to PHPCS. This PR backfills the PHPCS native array in the `BCTokens` class. Includes unit test. Includes updates to the array made in upstream PRs 3608 and 3610. Refs: * squizlabs/PHP_CodeSniffer 3484 * squizlabs/PHP_CodeSniffer 3608 * squizlabs/PHP_CodeSniffer 3610 Co-authored-by: Jaroslav Hanslík <kukulich@kukulich.cz>
jrfnl
deleted the
backcompat/bctokens-support-contextsensitivekeywords
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... as introduced in PHPCS 3.7.0 and updated in PHPCS 3.7.1.
Upstream PR squizlabs/PHP_CodeSniffer#3484 introduces a new
$contextSensitiveKeywordstokens array to PHPCS.This PR backfills the PHPCS native array in the
BCTokensclass.Includes unit test.
Includes updates to the array made in upstream PRs squizlabs/PHP_CodeSniffer#3608 and squizlabs/PHP_CodeSniffer#3610.
Refs: