Added PSR-2 documentation XML files

[blue32a]

Thank you for providing a great tool.

Description

I was looking into sniffs to create a coding standard for my project and it took me a long time to get to the generator.
I found some missing in the documentation and am submitting this PR.
Hope that helps.

Suggested changelog entry

• Added missing PSR-2 documentation XML files.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• This change is only breaking for integrators, not for external standards or end-users.
• Documentation improvement

PR checklist

• I have checked there is no other PR open for the same change.
• I have read the Contribution Guidelines.
• I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
• I have added tests to cover my changes.
• I have verified that the code complies with the projects coding standards.
• [Required for new sniffs] I have added XML documentation for the sniff.
• [Required for new files] I have added any new files to the package.xml file.

[jrfnl]

@blue32a Thank you for your willingness to contribute.

I have reviewed these XML docs, checked for common mistakes and tested them in CLI.

Findings:

• PSR2.Files.ClosingTag: ✅
• PSR2.Methods.FunctionClosingBrace: I'd recommend some minor tweaks to the code sample descriptions to make it more obvious what the sniff is looking for.
• PSR2.Methods.FunctionCallSignature:
  • The code samples used aren't function calls, while the sniff is about function calls.
  • I'd recommend some tweaks to the code sample descriptions to make it more obvious what the sniff is looking for.
  • There are numerous additional checks the sniff does, but which are not mentioned in the docs.
    This is not a blocker, as those can be added at a later time, but it should be noted all the same.
    Extra checks currently not mentioned:
    • First argument in a multi-line function call must be on a new line.
    • Only one argument per line in a multi-line function call.
    • No blank lines in a multi-line function call.

[jrfnl]

Suggested change

	foo<em> </em>(<em> </em>$bar, $baz<em> </em>) {
	}
	foo<em> </em>(<em> </em>$bar, $baz<em> </em>)<em> </em>;

[jrfnl]

P.S.: The new files should also be added to the package.xml file.

[blue32a]

@jrfnl Thank you for your review.

I have updated the PR with your findings.

[jrfnl]

@blue32a Hiya, thanks for making those updates! The docs all look good to me now.

Only thing left to do is to update the package.xml file - as noted above, the three new files need to be added to the file list in the package.xml file.

[blue32a]

I had missed it.
Three new documents have been added to package.xml.

[jrfnl]

I had missed it. Three new documents have been added to package.xml.

@blue32a Thank you! All looks good to me now ✅

[jrfnl]

FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release.

As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo).